wakatime / browser-wakatime

Chrome extension for automatic time tracking and metrics generated from your browsing activity.
https://wakatime.com
BSD 3-Clause "New" or "Revised" License
397 stars 94 forks source link

Typo in WakaTimeCore.ts L259 #215

Open toptalo opened 1 year ago

toptalo commented 1 year ago

I think there are typo

https://github.com/wakatime/browser-wakatime/blob/c4029f5fee62e69c68fa6731cc5dc4d1c30a07b2/src/core/WakaTimeCore.ts#L259 Should be

const lineRe = new RegExp(cleanLine.replace('.', '\\.').replace('*', '.*')); 
toptalo commented 1 year ago

Also on line 264 https://github.com/wakatime/browser-wakatime/blob/c4029f5fee62e69c68fa6731cc5dc4d1c30a07b2/src/core/WakaTimeCore.ts#L264

I think should be projectName instead of null

toptalo commented 1 year ago

Why i am here:

I want to track my activity in google chats URL looks like https://mail.google.com/chat/u/1/?zx=XXXXXXXXX#chat/space/AAAAxxXXXXX ?zx= search param can be suddenly changed. /space/ is ID of chat (project) So I have add asterisk in place of changeable part of URL to my whitelist, like so: https://mail.google.com/chat/u/1/*/space/AAAAxxXXXXX@@projectName

But in WakaTime Icon I see This URL is not in your whitelist