wakatime / desktop-wakatime

Windows & Linux system tray app for automatic time tracking and metrics generated from your Figma, Postman, etc. usage.
https://wakatime.com/windows
BSD 3-Clause "New" or "Revised" License
26 stars 6 forks source link

Electron build is not working on windows #10

Open dhufnagel opened 4 weeks ago

dhufnagel commented 4 weeks ago

The build on windows fails due to electron package for Windows universal is not found:

• packaging platform=win32 arch=universal electron=29.1.6 appOutDir=release\0.1.0\win-universal-unpacked ⨯ cannot resolve https://github.com/electron/electron/releases/download/v29.1.6/electron-v29.1.6-win32-universal.zip: status code 404

If i remove "universal" from electron-builder.json for windows, the setup is created, but the application is not working as expected after the installation. The settings and monitored app views are not found: image

iam-rohid commented 4 weeks ago

Thanks, @dhufnagel for introducing this bug. I'm looking into it.

iam-rohid commented 4 weeks ago

Marged PR #11 should fix the issue "The settings and monitored app views are not found".

dhufnagel commented 4 weeks ago

I think the builder still is not working, as the universal electron package is not available to download.

iam-rohid commented 3 weeks ago

Can you share the whole build output log? And, Are you using an Intel/x64 Windows device?

dhufnagel commented 3 weeks ago

Well I guess the provided log says all:

cannot resolve https://github.com/electron/electron/releases/download/v29.1.6/electron-v29.1.6-win32-universal.zip: status code 404

The electron-builder.json contains universal as platform, but electron does not provide universal as platform (anymore?): https://github.com/wakatime/desktop-wakatime/blob/5caa8e6afbe7d7baab556b51e375174ed325b8c0/electron-builder.json#L24

If you remove the "unviersal" from the array, the build is working. But the file it tries to download for universals truely is not available: https://github.com/electron/electron/releases/download/v29.1.6/electron-v29.1.6-win32-universal.zip

gandarez commented 3 weeks ago

@dhufnagel It should be fixed with latest release, can you please download from here and let me know?