wakatime / macos-wakatime

Mac system tray app for automatic time tracking and metrics generated from your Xcode, Figma, Postman, etc. usage.
https://wakatime.com/mac
BSD 3-Clause "New" or "Revised" License
126 stars 22 forks source link

Add browser activity filter #234

Closed starbugs closed 3 months ago

starbugs commented 3 months ago

I took the liberty to redesign the Settings window a bit:

Screenshot 2024-03-21 at 13 33 32

The whitelist also supports the @@ syntax.

Closes #196

alanhamlett commented 3 months ago

Let's rename to allow and deny lists, like: all except denied sites

alanhamlett commented 3 months ago

I don't like the @@ syntax, let's use structured UI and data?

starbugs commented 3 months ago

I don't like the @@ syntax, let's use structured UI and data?

Not sure I understand exactly what you mean...

starbugs commented 3 months ago

Let's rename to allow and deny lists, like: all except denied sites

This is renamed now.

Let me know what to do about the @@ syntax then I will finalize this PR.

alanhamlett commented 3 months ago

For @@, we should build into the UI the ability to assign a project to a domain. We want to build a UI similar to custom rules on the website, where we have a button Add new project rule that adds a new form row with two input fields url regex and project. When the full url matches a regex, we use the corresponding project name.

For now, let's just not support the @@ syntax and build the Custom Project Regex feature in a future PR.

alanhamlett commented 3 months ago

Also, we need a setting to toggle sending full url or domain-only for browsing activity.

alanhamlett commented 3 months ago

Actually, let's make the allow/deny list regexes which can match the full url.

starbugs commented 3 months ago

Actually, let's make the allow/deny list regexes which can match the full url.

I implemented that and removed the @@ syntax.

Do you want to add something to the remarks below the text view?

alanhamlett commented 3 months ago

Actually, let's make the allow/deny list regexes which can match the full url.

I implemented that and removed the @@ syntax.

Thank you! That's so much better than @@ syntax.