search

wakatime / macos-wakatime

Mac system tray app for automatic time tracking and metrics generated from your Xcode, Figma, Postman, etc. usage.
https://wakatime.com/mac
BSD 3-Clause "New" or "Revised" License
128 stars 22 forks source link

Only add the app as login item in release mode #65

Closed starbugs closed 1 year ago

starbugs commented 1 year ago

Alan said "We should be able to disable adding as login item when built in Debug profile, then change GitHub Actions to build with a Release profile?"

This adds the debug mode check and only adds the app as a login item when in release mode.

I am not sure what (or if anything) needs to be changed in the GitHub Action?

Fixes #34.

alanhamlett commented 1 year ago

I am not sure what (or if anything) needs to be changed in the GitHub Action?

I think we're building in the default Debug profile even in GitHub Actions. We need to change project.yml to generate a Release profile and use that when building in GitHub Actions.

starbugs commented 1 year ago

@alanhamlett I added a commit changing the GH action to Release mode. Since I cannot test this, I am not sure if it actually works.

alanhamlett commented 1 year ago

I am not sure if it actually works.

Let's merge and find out!

starbugs commented 1 year ago

Looks as if it failed, but in a step that I didn't touch in my change 🤔