search

wakatime / vscode-wakatime

Visual Studio Code plugin for automatic time tracking and metrics generated from your programming activity.
https://wakatime.com/vs-code
BSD 3-Clause "New" or "Revised" License
1.2k stars 133 forks source link

Resolve api_key_vault_cmd like wakatime-cli does #386

Closed kisaragi-hiu closed 3 months ago

kisaragi-hiu commented 3 months ago

This package was treating the entire config value of api_key_vault_cmd as one executable name, rather than treating it as a shell command --- but it also probably shouldn't treat it as a shell command, as wakatime-cli doesn't do that either.

wakatime-cli instead treats the value as a space-separated list of the executable and its arguments:

https://github.com/wakatime/wakatime-cli/blob/1fd560a/cmd/params/params.go#L707-L719

This PR makes vscode-wakatime mimick that behavior.

This should fix https://github.com/wakatime/vscode-wakatime/issues/387.

gandarez commented 3 months ago

It looks good to me, wdyt @alanhamlett?