Closed gandarez closed 3 months ago
Attention: Patch coverage is 40.00000%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 62.76%. Comparing base (
6a3fd24
) to head (c1f4340
).
@@ Coverage Diff @@
## develop #1040 +/- ##
===========================================
- Coverage 62.77% 62.76% -0.01%
===========================================
Files 381 381
Lines 16333 16338 +5
===========================================
+ Hits 10253 10255 +2
- Misses 5526 5528 +2
- Partials 554 555 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 62.76% <40.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
pkg/offline/offline.go | 56.41% <40.00%> (-0.24%) |
:arrow_down: |
This PR adds an extra layer of validation to bbolt when closing it. There are some users getting panic to close it making the whole heartbeat to be gone.
logs