search

wakatime / wakatime-cli

Command line interface used by all WakaTime text editor plugins
https://wakatime.com/plugins
BSD 3-Clause "New" or "Revised" License
297 stars 41 forks source link

Research and possibly implement using KEYWORDS as dependencies when found in Html files #203

Open alanhamlett opened 3 years ago

alanhamlett commented 3 years ago

The Python cli used to look for keywords, such as ember or backbone, in Html files and assume those keywords being present means the associated JavaScript library was being included on the page with a script tag. It would then use the found keyword as a dependency, adding it to the list of detected dependencies for the current heartbeat:

https://github.com/wakatime/legacy-python-cli/commit/166f41899c43bbed259103d401920feb309b2db1#diff-e99152f6ea6bc64e5a34bf5cebaed10862f3abec05aa3528fa8ff8ed892b37ecR88

Sometime after launching 1.0, let's research if this is still needed, if it was replaced with another detection method, and if we should add it back to wakatime-cli's Html parser.

More info in Slack: https://wakatime.slack.com/archives/GUWD67UE4/p1609032466002300

Related to #148.

gandarez commented 1 year ago

@alanhamlett the link to the commit is broken. Do you know where it's implemented?

alanhamlett commented 1 year ago

Fixed the link to the commit.