wakatime / wakatime-mode

Emacs plugin for automatic time tracking and metrics generated from your programming activity.
https://wakatime.com/emacs
267 stars 41 forks source link

string-replace is not a valid eMacs function in 27.2 #68

Open may opened 1 year ago

may commented 1 year ago

I don’t think it’s a valid function it any eMacs, but I can confirm it’s not in 27.2.

Line 122 from the MELPA version breaks, causing the user not to be prompted for path.

Consider using replace-string instead

dotemacs commented 1 year ago

I just hit this snag too and I just replaced instances string-replace with replace-string before finding your issue above.

I guess this is a bug that should be fixed.

But since this package will need to handle some older Emacs versions too, it needs to conditionally test for the Emacs version number to apply this change...