search

wakatime / wakatime-mode

Emacs plugin for automatic time tracking and metrics generated from your programming activity.
https://wakatime.com/emacs
267 stars 41 forks source link

RFC: `wakatime-find-binary` improvement #72

Open pataquets opened 10 months ago

pataquets commented 10 months ago

I need to look for Wakatime's cli binary in ~/.local/bin. I'm aware I can manually configure it via wakatime-cli-path (my current workaround), but I was expecting it to work out of the box, as it's a common dir.

As per XDG Base Directory Specification, ~/.local/bin may contain user binaries. Also, ~/bin is also a common binary location (at least in Ubuntu's default .profile: filesystem - What's the purpose of $HOME/bin directory? - Ask Ubuntu)

Checking the code, neither of the above paths is checked. At first I thought on adding them and sending a PR. On second thought, I wonder why is not executable-find being used. Maybe some function's built-in behavior is not desired.

Before going further, some feedback would be appreciated.

pataquets commented 9 months ago

@alanhamlett ping in case issue notification went unnoticed.