search

wakdev / slash-cms

CMS Systems
GNU General Public License v3.0
5 stars 5 forks source link

Database optimisations #42

Closed lpotherat closed 11 years ago

lpotherat commented 11 years ago

Note : Check admin/modules/sla_categories/models/categories.php with winmerge or another visual file comparator, git didn't diff correctly.

Corrected a bug : text values could not contain quotes.

Database optimisation :

wakdev commented 11 years ago

"Note : Check admin/modules/sla_categories/models/categories.php with winmerge or another visual file comparator, git didn't diff correctly."

Yes, I see i must resolve conflicts before merge this commit. But, good improvement ! Like :)

lpotherat commented 11 years ago

Do not forget to use "escape" in future queries ;)

lowki commented 11 years ago

Pretty good work up there. Would be great to use prepared queries too. Le 11 avr. 2013 23:46, "lpotherat" notifications@github.com a écrit :

Do not forget to use "escape" in future queries ;)

— Reply to this email directly or view it on GitHubhttps://github.com/wakdev/slash-cms/pull/42#issuecomment-16263789 .

lpotherat commented 11 years ago

I think it will be my next improvement.

wakdev commented 11 years ago

And MySQLi connector :)

wakdev commented 11 years ago

I will merge tonight or tomorrow.

wakdev commented 11 years ago

I have done merging and resolving conflicts in this commit : https://github.com/wakdev/slash-cms/commit/1ecd1a19d788ff0ea544d7559bf8410052f671dc

So i close this pull request. Thank you for your great work.

Do not forget to update your fork, because... so many conflicts >_<