wake-0 / fhvOS

This repository contains an os for the arm cortex a8 in combination with beaglebone.
GNU General Public License v2.0
7 stars 1 forks source link

[Console] Extend the set of accepted characters #53

Closed trylimits closed 9 years ago

trylimits commented 9 years ago

The console should accept:

  1. blank character
  2. backspace
  3. " character
  4. * character
  5. | character
  6. . character
  7. and some more...
trylimits commented 9 years ago

1.) and 3-5.) done

Backspace support has to be implemented by overriding __backspace(..) (see. http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0378d/Chdjigab.html )

trylimits commented 9 years ago

6.) done

trylimits commented 9 years ago

I found an issue in using the `character. If there is already an input hitting space will return fromscanf`.

trylimits commented 9 years ago

Above commits solves the scanf issue. It wasn't actually a bug in our implementation :) See http://stackoverflow.com/questions/1247989/how-do-you-allow-spaces-to-be-entered-using-scanf

wake-0 commented 9 years ago

Which characters are missing at the moment?

trylimits commented 9 years ago

Backspace support for sure (but minor) and some other characters which we should add time after time (if needed). Marking this ticket as pending?

trylimits commented 9 years ago

The console should abort an empty input directly without making a system call.

trylimits commented 9 years ago

Above commits extends the set of accepted characters and fixed the bug of an empty input. However, we cannot get backspace support if we keep using scanf for the prompt input.

The current implementation can be considered a simple, working console which does not support:

1.) Backspace 2.) Command history (up down keys) 3.) Cursor movement

Overall we should consider to implement an advanced console. I will open a new ticket for this.