"Could not retrieve reaction for emoji" error on most/all reactions

wakfi commented 3 years ago

Short Description

"Could not retrieve reaction for emoji" error on most/all reactions other than 🗃 (side note: change error catch here to output e.stack)

Steps to Reproduce

React to a message
Check error log

Expected Result (how should it be behaving?)

Nothing should occur unless a behavior/feature has been specified for that reaction in that context.

Actual Result (what is the current behavior?)

An error is being recorded in the error log. This occurs with a high frequency.

Current Bot Version (run the `info` command and look at the footer)

d673686

wakfi commented 3 years ago

This should be investigated/fixed primarily on the commands-refactor branch rather than master, as it is non-critical

wakfi commented 3 years ago

Solution incoming from command-refactor, issue was from an early return in the main script's reaction handler that wasn't being treated properly. It was treated as an error condition rather than a normal case, which it can be when the last reaction of a given emoji is removed. The other issue was with how custom emojis were being looked up, the identifier was being set up wrong

wakfi / roboboi