Feature Request : Ratio handling

[GoogleCodeExporter]

Looking for the following : 

* Ratio Handling per torrent
* Ratio handling when torrents are add by RSS feed

Not sure if it's possible.
But would be great , so I don't seed to much ;-)

-------------------
rtorrent Ratio Handling :
http://libtorrent.rakshasa.no/wiki/RTorrentRatioHandling

Original issue reported on code.google.com by rascal...@gmail.com on 3 Aug 2009 at 6:35

[GoogleCodeExporter]

Original comment by novik65 on 4 Aug 2009 at 8:17

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

you can do ratio handling via watch directories now so i'm sure this is 
possible if
you set it up properly

Original comment by Wonslung@gmail.com on 5 Aug 2009 at 10:50

[GoogleCodeExporter]

yeah but the RSS plugin does not download to watch folders yet
So it should be implemented another way I guess

Original comment by rascal...@gmail.com on 5 Aug 2009 at 6:52

[GoogleCodeExporter]

Ahh, yes, this is very true.

Original comment by Wonslung@gmail.com on 7 Aug 2009 at 4:37

[GoogleCodeExporter]

Original comment by novik65 on 14 Aug 2009 at 1:05

• Changed state: Started

[GoogleCodeExporter]

Original comment by novik65 on 14 Aug 2009 at 1:06

[GoogleCodeExporter]

I saw this was added , tx for that.

Any hints/tips on what settings to change in .rtorrent.rc to get it working ?

As I use 0.8.5 , and it now says it's not supported

Original comment by rascal...@gmail.com on 17 Aug 2009 at 6:16

[GoogleCodeExporter]

It under construction now. I will change status, when plugin will be ready.

Original comment by novik65 on 17 Aug 2009 at 6:54

[GoogleCodeExporter]

OK I see , I already downloaded it .. lol.

Will wait , looks good so far 

Original comment by rascal...@gmail.com on 17 Aug 2009 at 7:12

[GoogleCodeExporter]

Finished. But if you want to test it, you need to get from svn latest core 
files too.
With core files from 2.6 version that plugin will'nt work.
RSS plugin on svn also has some changes for compability with ratio.

Original comment by novik65 on 17 Aug 2009 at 7:32

• Changed state: Done

[GoogleCodeExporter]

Yeah I saw that , so I grabbed RSS & Ratio plugin from svn.

But like I said I guess I also need to do something to .rtorrent.rc , as 
rutorrent
now tells me that ratio is not supported.

I am using the unstable version from svn (rtorrent 0.8.5) from about 2-3 weeks 
ago.
So that one can handle ratio groups

Original comment by rascal...@gmail.com on 18 Aug 2009 at 3:55

[GoogleCodeExporter]

Are you really sure, that version from SVN is 0.8.5? :)
"svn://rakshasa.no/libtorrent/trunk/rtorrent", ya?
I've done this mistake too. 
As I know, version 0.8.5 is available as tarball only, from here:
http://libtorrent.rakshasa.no/downloads/

Original comment by dmrom00 on 18 Aug 2009 at 4:50

[GoogleCodeExporter]

sorry , my mistake , I do not use the svn one.

When I start rtorrent I see :   *** rTorrent 0.8.5/0.12.5 

maybe I get this error because i have ratio set already in my rc like this : 

# Enable the default ratio group.
ratio.enable=yes

# Change the limits, the defaults should be sufficient.
ratio.min.set=300
ratio.max.set=300
ratio.upload.set=500M

Original comment by rascal...@gmail.com on 18 Aug 2009 at 6:20

[GoogleCodeExporter]

so this only works with rtorrent svn? i use the devel version in ports....
the latest STABLE is 0.8.4....the svn was 0.8.5 i thought....i know
ports/net-p2p/rtorrent-devel is 0.8.5 and ports/net-p2p/rtorrent is 0.8.4 so i'm
confused now

Original comment by Wonslung@gmail.com on 18 Aug 2009 at 6:41

[GoogleCodeExporter]

This only works with *ruTorrent* from svn. And for rTorrent >= 0.8.4. Are you 
grabbed
from svn ruTorrent core files?

Original comment by novik65 on 18 Aug 2009 at 7:10

[GoogleCodeExporter]

Yeah i grabbed rutorrent from svn
copied all files, added my settings.

but still get the error that it does not support ratio.
Do you need a special setting in the .rc ?

Original comment by rascal...@gmail.com on 18 Aug 2009 at 8:50

[GoogleCodeExporter]

>Do you need a special setting in the .rc ?

No.

1) Open file rtorrent/xmlrpc.php, uncomment lines

//toLog($this->content);
            $answer = send2RPC($this->content);
//toLog($answer);

like that:

toLog($this->content);
            $answer = send2RPC($this->content);
toLog($answer);

2) Reload ruTorrent in browser. Do not touch anything.
3) Find file /tmp/error.log and attach it to issue.
4) Comment back lines from point 1.

Original comment by novik65 on 18 Aug 2009 at 9:00

[GoogleCodeExporter]

>Yeah i grabbed rutorrent from svn copied all files, added my settings.

How you do that? Copy file by file from http (get
http://rutorrent.googlecode.com/svn/trunk/rtorrent/Snoopy.class.inc etc.) or use
commands svn checkout/svn update?
First method is wrong, you need to use second.

Original comment by novik65 on 18 Aug 2009 at 9:05

[GoogleCodeExporter]

I did the following : 

svn checkout http://rutorrent.googlecode.com/svn/trunk/rtorrent rutorrent
cd rutorrent
rm -r plugins
svn checkout http://rutorrent.googlecode.com/svn/trunk/plugins

And then send all thiose files to the webfolder , change the RPC settings.

Original comment by rascal...@gmail.com on 18 Aug 2009 at 9:17

[GoogleCodeExporter]

see attached the error file

Original comment by rascal...@gmail.com on 18 Aug 2009 at 9:23

Attachments:

• error.log

[GoogleCodeExporter]

Fixed in r315. Update core files from svn.

Original comment by novik65 on 18 Aug 2009 at 9:59

[GoogleCodeExporter]

Don't have the msg anymore.
So looks like it's working , now wait till a download goes over the normal ratio

But so far it looks goo , tx for this

Original comment by rascal...@gmail.com on 18 Aug 2009 at 1:22

[GoogleCodeExporter]

i have rutorrent svn but i have rtorrent 0.8.5

is there ANYWAY we can make it work with 0.8.5

Original comment by Wonslung@gmail.com on 18 Aug 2009 at 4:57

[GoogleCodeExporter]

@Wonslung : it works with 0.8.5 , as i did the same install as you.

What I had to uncomment to get it working was  :

# Enable the default ratio group. # Enable the default ratio group. 
 ratio.enable=yes ratio.enable = yes 

 # Change the limits, the defaults should be sufficient. # Change the limits, the
defaults should be sufficient. 
 ratio.min.set=300 ratio.min.set = 300 
 ratio.max.set=300 ratio.max.set = 300 
 ratio.upload.set=500M ratio.upload.set = 500M 

after that it works perfect

Original comment by rascal...@gmail.com on 18 Aug 2009 at 5:14

[GoogleCodeExporter]

>>is there ANYWAY we can make it work with 0.8.5
>What I had to uncomment to get it working was

I think, plugin must work without such lines in rtorrent.rc. On my two systems
(rtorrent 0.8.4 & 0.8.5) it is worked. What it say on you configuration?

Original comment by novik65 on 19 Aug 2009 at 7:21

[GoogleCodeExporter]

originally i was getting a bug, but now i see no error message so i will test 
to see
if it is ACTUALLY working, amazing job.  

One question though....i see you can set a min max and size...which one does it 
look
at FIRST?

like...if i set a ratio for a minimum of 100% a maximum of 200% and 100 MB what 
will
happen if it is a 700 MB movie?  will it seed back 700 MB, 1400 MB or just 100 
MB?

Original comment by Wonslung@gmail.com on 19 Aug 2009 at 9:05

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

In simple words, your example will stop a torrent once it has uploaded 100% of 
the
torrent size, unless less than 100MB has been uploaded and the ratio is below 
200%. 

Original comment by novik65 on 20 Aug 2009 at 7:29

[GoogleCodeExporter]

so if i want to set it to always seed 100% back i'd set the first 2 to 100% and 
set
the MB to 0?

Original comment by Wonslung@gmail.com on 21 Aug 2009 at 6:35

[GoogleCodeExporter]

Err... My english is to bad for understanding this, write simple. rTorrent use 
that
algorithm:

if((uploadedNow >= minUpload && uploadedNow * 100 >= sizeOfAllFiles * minRatio) 
|| 
   (maxRatio > 0 && uploadedNow * 100 > sizeOfAllFiles * maxRatio)) 
   apply_stop_command_for_this_seeding();

where minRatio, maxRatio and minUpload - ratio parameters,
uploadedNow and sizeOfAllFiles - current torrent's parameters.
For your example from comment26 we have:

if((uploadedNow >= 100 && uploadedNow * 100 >= 700 * 100) || 
   (200 > 0 && uploadedNow * 100 > 700 * 200)) 
   apply_stop_command_for_this_seeding();

write this more simple:

if((uploadedNow >= 100 && uploadedNow >= 700) || 
   (uploadedNow > 1400)) 
   apply_stop_command_for_this_seeding();

and yet more simple:

if(uploadedNow >= 100) 
   apply_stop_command_for_this_seeding();

Original comment by novik65 on 21 Aug 2009 at 7:39

[GoogleCodeExporter]

ahh, thank you, i understand better now =)

Original comment by Wonslung@gmail.com on 26 Aug 2009 at 9:00

[GoogleCodeExporter]

BTW, error is happens above - must be

"and yet more simple:

if(uploadedNow >= 700) 
   apply_stop_command_for_this_seeding();"

;)))

Original comment by novik65 on 2 Oct 2009 at 1:29