bug: don't ping all connected peers continuously

waku-org / go-waku

Go implementation of Waku v2 protocol

https://waku.org/

Other

112 stars 43 forks source link

bug: don't ping all connected peers continuously #1147

Open chaitanyaprem opened 4 days ago

chaitanyaprem commented 4 days ago

Describe the bug We ping all the connected peers every fixed interval which helps us determine if we are connected or not. But with recent changes to enable relay to connect to upto 300 peers, this will increase un-necessary traffic and noise.

Instead we should ping only to few peers(maybe 5-10) every interval chosen randomly rather than all of them.

WDYT @richard-ramos

richard-ramos commented 4 days ago

Yeah i agree. Pinging all peers only made sense before the max connected peers change.