search

waku-org / go-waku

Go implementation of Waku v2 protocol
https://waku.org/
Other
117 stars 42 forks source link

bug: metadata is not always checking shards for relay peer connectivity #1156

Open chaitanyaprem opened 2 months ago

chaitanyaprem commented 2 months ago

Describe the bug after this change , metadata sometimes is considering relay peer as lightclient, probably because identify did not happen till that time. Hence only clusterID check is done in this case.

This is ok for status since as of now community specific sharding is not implemented and all nodes support all shards. But, this needs to be fixed once sharding for communities is to be implemented.

Similarly for lightClients, shardInfo should be updated in metadata based on filter subscriptions or during init time - TBD

Expected behavior relay peers should always be verified of matching shards after connecting.

chaitanyaprem commented 1 month ago

Similarly for lightClients, shardInfo should be updated in metadata based on filter subscriptions or during init time - TBD

this may not be required for current community sharding because all fleet nodes support all shards and every user would have to support shards 32 and 64(common shards) which are anyways indicated for lightclient during init. So, metadata should not disconnect any peers.

similarly this change is not required in current milestones.