Closed fryorcraken closed 1 year ago
I am still not able to determine good API to cover this so @fryorcraken do you see other points for improvement here?
I see you have done improvement already with #43 . Let's use it in the examples and see how it looks.
Ok, so I'll define as follow up item next thing:
Problem
Retrieving membership details and adding them to the
RlnInstance
is something that any user of js-rln should do and are likely to copy-paste from https://github.com/waku-org/js-waku-examples/blob/b6d9942b113e51298ba9e4405997c3dc52bec908/rln-js/index.html#L259Same re listening to contract event add new memberships to
RlnInstance
.Same re registering membership in contract: https://github.com/waku-org/js-waku-examples/blob/b6d9942b113e51298ba9e4405997c3dc52bec908/rln-js/index.html#L287
Solution
Provide a function helper that does that.
2 possibilities:
ethers
, hence we can setethers
as an optional dependencyethers
andweb3js
.Not sure (2) is straight forward, might be easier to just go with (1) for now
Acceptance Criteria
RlnInstance
and add new members toRlnInstance
by listening to contract