waku-org / js-rln

Browser library providing the cryptographic functions for Waku RLN Relay https://rfc.vac.dev/spec/17/
Apache License 2.0
5 stars 1 forks source link

Track package size to provide valuable insight to developer #46

Open fryorcraken opened 1 year ago

fryorcraken commented 1 year ago

See https://github.com/ai/size-limit/issues/299#issuecomment-1308620699

weboko commented 1 year ago

Applicable to js-waku as well.

fryorcraken commented 1 year ago

Applicable to js-waku as well.

We tracked in js-waku PRs. Already, what more are you thinking of?

weboko commented 1 year ago

I would add point to revisit how and what exactly we track in js-waku (I see core is tracked) Another improvement I would introduce is this, so that we will have a job failed at the over-the-budget change. This brings us into discussion what is an ideal size we'd like to have - additional research should be done.

fryorcraken commented 1 year ago

I would add point to revisit how and what exactly we track in js-waku (I see core is tracked) Another improvement I would introduce is this, so that we will have a job failed at the over-the-budget change. This brings us into discussion what is an ideal size we'd like to have - additional research should be done.

Happy to track to revisit. size-limit does provide a similar feature, it's just not used.