search

waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
166 stars 42 forks source link

chore: allow release please to sign commits #1247

Open weboko opened 1 year ago

weboko commented 1 year ago
This is a **support request** ## Problem Currently we had to remove hard rule for all commits to be signed to unblock the release https://github.com/waku-org/js-waku/pull/1237 ## Proposed Solutions We need to add GPG token to allow `release-please` to sign it's commits https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#gpg-commit-signature-verification
weboko commented 1 year ago

Putting on hold for the time being since release-please underlying library does not support it and there is no workaround for now.

https://github.com/googleapis/code-suggester/issues/337