waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
167 stars 42 forks source link

only allow secure websockets on transport #1547

Closed danisharora099 closed 4 months ago

danisharora099 commented 1 year ago
This is a **bug report/feature or change request/support request** ## Problem js-waku currently filters and tries to dial all peers that support websockets on the transport level. this leads to a lot of failures when dialing from browsers. ## Proposed Solutions we can perhaps limit that to only allow secure websockets (`wss`), but allow non-secure websockets (`ws`) on `localhost` if possible. ## Notes - ref: https://github.com/orgs/waku-org/projects/2/views/1?pane=issue&itemId=37511644
weboko commented 4 months ago

Moving to in progress as some work has been done by @adklempner: