waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
162 stars 41 forks source link

chore: investigate transient Safari disconnect failures #1608

Open weboko opened 9 months ago

weboko commented 9 months ago
This is a **bug report** ## Problem After adding https://github.com/waku-org/js-waku/pull/1598 it happens that sometimes `browser` testing fails due to `Safari` browser disconnecting. It happens only for `@waku/message-encryption` package. ## Proposed Solutions Investigate and mitigate. ## Notes Links for help: https://github.com/karma-runner/karma-chrome-launcher/issues/154, https://github.com/google/karma-webkit-launcher ## Logs Example of a failed run https://github.com/waku-org/js-waku/actions/runs/6275811677/job/17045073849 ``` Safari 16.4 (Linux x86_64): Executed 18 of 18 (1 FAILED) (20.032 secs / 19.867 secs) Safari 16.4 (Linux x86_64): Executed 18 of 18 (1 FAILED) (19.739 secs / 19.518 secs) Firefox 117.0 (Linux x86_64): Executed 18 of 18 (1 FAILED) (0 secs / 19.672 secs) Safari 16.4 (Linux x86_64): Executed 2 of 18 (1 FAILED) (0 secs / 8.191 secs) Safari 16.4 (Linux x86_64): Executed 1 of 18 SUCCESS (0 secs / 3.729 secs) Chrome Headless 117.0.5938.62 (Linux x86_64): Executed 18 of 18 (1 FAILED) (11.757 secs / 11.739 secs) Safari 16.4 (Linux x86_64): Executed 18 of 18 (1 FAILED) (20.032 secs / 19.867 secs) Safari 16.4 (Linux x86_64): Executed 18 of 18 (1 FAILED) (19.739 secs / 19.518 secs) Firefox 117.0 (Linux x86_64): Executed 18 of 18 (1 FAILED) (19.752 secs / 19.672 secs) Safari 16.4 (Linux x86_64): Executed 2 of 18 (1 FAILED) (0 secs / 8.191 secs) Safari 16.4 (Linux x86_64): Executed 1 of 18 SUCCESS (0 secs / 3.729 secs) TOTAL: 5 FAILED, 70 SUCCESS 22 09 2023 15:25:01.422:WARN [Safari 16.4 (Linux x86_64)]: Disconnected (0 times) Client disconnected from CONNECTED state (server shutting down) Safari 16.4 (Linux x86_64) ERROR Disconnected Client disconnected from CONNECTED state (server shutting down) Chrome Headless 117.0.5938.62 (Linux x86_64): Executed 18 of 18 (1 FAILED) (11.757 secs / 11.739 secs) Safari 16.4 (Linux x86_64): Executed 18 of 18 (1 FAILED) (20.032 secs / 19.867 secs) Safari 16.4 (Linux x86_64): Executed 18 of 18 (1 FAILED) (19.739 secs / 19.518 secs) Firefox 117.0 (Linux x86_64): Executed 18 of 18 (1 FAILED) (19.752 secs / 19.672 secs) Safari 16.4 (Linux x86_64): Executed 2 of 18 (1 FAILED) (0 secs / 8.191 secs) Safari 16.4 (Linux x86_64): Executed 1 of 18 SUCCESS (0 secs / 3.729 secs) npm ERR! Lifecycle script `test:browser` failed with error: npm ERR! Error: command failed npm ERR! in workspace: @waku/message-encryption@0.0.21 npm ERR! at location: /home/runner/work/js-waku/js-waku/packages/message-encryption Error: Process completed with exit code 1. ```
weboko commented 9 months ago

Removing Safari from running for now