waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
166 stars 42 forks source link

fix: remove rpc settings when starting nwaku image #1880

Closed adklempner closed 6 months ago

adklempner commented 6 months ago

Problem

Per nwaku team, all rpc flags will no longer exist after v0.26.0 release. Our tests try to start nwaku with those flags passed, and that causes problems when running against newest version.

Solution

Remove all rpc flags from Docker args when starting nwaku ## Notes
github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 185.25 KB (0%) 3.8 s (0%) 13.9 s (+74.21% 🔺) 17.6 s
Waku Simple Light Node 185.27 KB (0%) 3.8 s (0%) 14.3 s (+30.36% 🔺) 18 s
ECIES encryption 22.89 KB (0%) 458 ms (0%) 2.5 s (+4.84% 🔺) 2.9 s
Symmetric encryption 22.34 KB (0%) 447 ms (0%) 2.4 s (-34.52% 🔽) 2.8 s
DNS discovery 70.06 KB (0%) 1.5 s (0%) 5.9 s (-21.73% 🔽) 7.3 s
Privacy preserving protocols 39.84 KB (0%) 797 ms (0%) 5.1 s (-31.67% 🔽) 5.9 s
Light protocols 20.58 KB (0%) 412 ms (0%) 3.5 s (+20.36% 🔺) 4 s
History retrieval protocols 19.34 KB (0%) 387 ms (0%) 1.2 s (-62.09% 🔽) 1.6 s
Deterministic Message Hashing 4.96 KB (0%) 100 ms (0%) 418 ms (-61.53% 🔽) 517 ms