waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
166 stars 42 forks source link

fix(tests): sharding: same cluster, different shard #1893

Closed danisharora099 closed 5 months ago

danisharora099 commented 6 months ago

Problem

The tests written to check connection for nodes when the cluster is same, but the shard is different, was expected to have the nodes connect. This worked fine interop until nwaku rc 0.24.0 With the introduction of the metadata protocol, the tests started to fail since this should not be allowed and the actual expectation from the test is that the nodes should not connect

Solution

Notes

Contribution checklist:

github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 185.24 KB (0%) 3.8 s (0%) 1.9 s (+28.14% 🔺) 5.6 s
Waku Simple Light Node 185.17 KB (0%) 3.8 s (0%) 1.9 s (+55.94% 🔺) 5.6 s
ECIES encryption 22.89 KB (0%) 458 ms (0%) 405 ms (+51.21% 🔺) 862 ms
Symmetric encryption 22.34 KB (0%) 447 ms (0%) 292 ms (-52.14% 🔽) 739 ms
DNS discovery 69.95 KB (0%) 1.4 s (0%) 1.2 s (+49.01% 🔺) 2.6 s
Privacy preserving protocols 39.84 KB (0%) 797 ms (0%) 944 ms (+51.27% 🔺) 1.8 s
Light protocols 20.58 KB (0%) 412 ms (0%) 311 ms (+14.4% 🔺) 723 ms
History retrieval protocols 19.34 KB (0%) 387 ms (0%) 361 ms (+45.95% 🔺) 748 ms
Deterministic Message Hashing 4.96 KB (0%) 100 ms (0%) 22 ms (-67.48% 🔽) 121 ms