github-actions[bot]
commented
5 months ago size-limit report 📦
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| Waku node | 180.82 KB (-2.66% 🔽) | 3.7 s (-2.66% 🔽) | 18 s (+13.43% 🔺) | 21.6 s |
| Waku Simple Light Node | 180.86 KB (-2.48% 🔽) | 3.7 s (-2.48% 🔽) | 15.9 s (+23.11% 🔺) | 19.5 s |
| ECIES encryption | 23.11 KB (+1% 🔺) | 463 ms (+1% 🔺) | 3.3 s (-1.89% 🔽) | 3.8 s |
| Symmetric encryption | 22.58 KB (+0.75% 🔺) | 452 ms (+0.75% 🔺) | 4 s (-4.04% 🔽) | 4.4 s |
| DNS discovery | 72.4 KB (-1.73% 🔽) | 1.5 s (-1.73% 🔽) | 14.3 s (+4.18% 🔺) | 15.7 s |
| Peer Exchange discovery | 73.97 KB (-1.86% 🔽) | 1.5 s (-1.86% 🔽) | 15.6 s (+13.26% 🔺) | 17.1 s |
| Local Peer Cache Discovery | 67.71 KB (-1.86% 🔽) | 1.4 s (-1.86% 🔽) | 7.8 s (+2.73% 🔺) | 9.2 s |
| Privacy preserving protocols | 38.75 KB (-3.05% 🔽) | 775 ms (-3.05% 🔽) | 6.1 s (-43.28% 🔽) | 6.9 s |
| Waku Filter | 20.17 KB (+0.31% 🔺) | 404 ms (+0.31% 🔺) | 4.1 s (+18.57% 🔺) | 4.5 s |
| Waku LightPush | 110.08 KB (-4.62% 🔽) | 2.3 s (-4.62% 🔽) | 17.3 s (+34.9% 🔺) | 19.5 s |
| History retrieval protocols | 110.77 KB (-4.55% 🔽) | 2.3 s (-4.55% 🔽) | 17.5 s (+46.88% 🔺) | 19.7 s |
| Deterministic Message Hashing | 4.83 KB (-2.55% 🔽) | 97 ms (-2.55% 🔽) | 151 ms (-54.51% 🔽) | 248 ms |
Problem
The new release of
protonschanges how they compile proto definitions intotsfiles which breaks our commited proto code CI check ref: https://github.com/waku-org/js-waku/pull/1932We are deprecating a few packages like
@waku/peer-exchange,@waku/dns-discovery, etc in favour of introducing a new package@waku/discovery: #1876 which leaves (non-breaking) stale references and outdated entriesalso: https://github.com/waku-org/js-waku/actions/runs/8209802396/job/22456033863?pr=1889
Solution
This should be followed by generating a new lockfile (ref: https://github.com/waku-org/js-waku/pull/1810#issuecomment-1930653179)
Notes
protodefinitions into thelibsubdir and the generated TS files into thegensubdir