Closed fbarbu15 closed 1 month ago
@fbarbu15 I'm not sure I fully understand this issue. clusterId
is indeed taken into account with ApplicationInfo
.
What am I missing?
https://github.com/waku-org/js-waku/blob/4db508b962736426f4897995a2b525c82fe0ba37/packages/utils/src/common/sharding.ts#L63-L70
cc @waku-org/js-waku-developers
Sorry, totally forgot about this issue I've applied this fix when I worked on js-waku sharding tests If it's not correct please feel free to revert/fix it
Closing according to the above comment
This is a bug report
Problem
shardInfoToPubsubTopics and ensureShardingConfigured doesn't take
clusterId
into consideration when resolving thePubsubTopic
forApplicationInfo
IMO this needs to work because
ApplicationInfo
also containsclusterId
and I expect thePubsubTopic
to match itProposed Solutions
clusterId
needs to be passed tocontentTopicToPubsubTopic
in those 2 functions