feat: create @waku/rln - Githubissues

waku-org / js-waku

JavaScript implementation of Waku v2

https://js.waku.org

Apache License 2.0

166 stars 42 forks source link

feat: create @waku/rln #1905

Closed weboko closed 2 months ago

weboko commented 5 months ago

Problem

@waku/rln is placed in a different repo with it's release pipeline

Solution

Make it part of js-waku

Notes

Resolves https://github.com/waku-org/js-rln/issues/76

TODO:

fixing some checks;
double check pipelines

Overall review can be started.

weboko commented 5 months ago

@danisharora099 thanks for the comments, I propose to have those that are actionable as follow ups

danisharora099 commented 5 months ago

@danisharora099 thanks for the comments, I propose to have those that are actionable as follow ups

Let's address the non-nit ones that are more important such as: not redefining tsconfig again, reusing the function from @waku/utils instead of redefining, etc. If you prefer, I'm happy to make commits to address these.

Nits can be addressed in a followup PR!

weboko commented 2 months ago

Closing for now