Closed yakimant closed 6 months ago
One issues from CI:
src/utils/discovery.ts:17:23 - error TS7053: Element implicitly has an 'any' type because expression of type '"SANDBOX"' can't be used to index type '{ TEST: string; PROD: string; }'.
Property 'SANDBOX' does not exist on type '{ TEST: string; PROD: string; }'.
17 wakuDnsDiscovery([enrTree["SANDBOX"]], DEFAULT_NODE_REQUIREMENTS),
Which are taken from https://github.com/waku-org/js-waku/blob/901e648d81a4a5cdd41683b226fe01daa1be41b3/packages/sdk/src/utils/discovery.ts#L2
Which is taken from https://www.npmjs.com/package/@waku/dns-discovery
Which is taken from https://github.com/waku-org/js-waku/
I wonder, how can we update the dns-discovery (and maybe other packages) with new names?
Second issue is Check all protobuf code was committed
:
Run res=$(git status --short --ignore-submodules)
res=$(git status --short --ignore-submodules)
echo -n "'$res'" # For debug purposes
[ $(echo -n "$res"|wc -l) -eq 0 ]
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
NODE_JS: 18
npm_config_cache: /home/runner/.npm
' M packages/core/src/lib/predefined_bootstrap_nodes.ts
M packages/discovery/src/dns/constants.ts
M packages/enr/src/enr.spec.ts
M packages/tests/tests/dns-peer-discovery.spec.ts'
Error: Process completed with exit code 1.
Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
---|---|---|---|---|
Waku node | 180.85 KB (+0.15% 🔺) | 3.7 s (+0.15% 🔺) | 12.5 s (-4.38% 🔽) | 16.1 s |
Waku Simple Light Node | 180.73 KB (-0.02% 🔽) | 3.7 s (-0.02% 🔽) | 14.4 s (+31.14% 🔺) | 18 s |
ECIES encryption | 23.11 KB (0%) | 463 ms (0%) | 3.8 s (-1.86% 🔽) | 4.2 s |
Symmetric encryption | 22.58 KB (0%) | 452 ms (0%) | 6.8 s (+164.66% 🔺) | 7.2 s |
DNS discovery | 72.4 KB (0%) | 1.5 s (0%) | 8.8 s (-22.39% 🔽) | 10.2 s |
Peer Exchange discovery | 73.97 KB (0%) | 1.5 s (0%) | 13.7 s (+39.15% 🔺) | 15.2 s |
Local Peer Cache Discovery | 67.71 KB (0%) | 1.4 s (0%) | 7.6 s (-13.72% 🔽) | 8.9 s |
Privacy preserving protocols | 38.75 KB (0%) | 775 ms (0%) | 7.3 s (+27.68% 🔺) | 8 s |
Waku Filter | 20.17 KB (0%) | 404 ms (0%) | 3.2 s (+6.58% 🔺) | 3.6 s |
Waku LightPush | 110.12 KB (0%) | 2.3 s (0%) | 10.3 s (+6.6% 🔺) | 12.6 s |
History retrieval protocols | 110.62 KB (0%) | 2.3 s (0%) | 10.8 s (-10.13% 🔽) | 13 s |
Deterministic Message Hashing | 4.83 KB (0%) | 97 ms (0%) | 654 ms (-55% 🔽) | 751 ms |
See https://github.com/status-im/infra-nim-waku/issues/91 for details
Mostly done automatically. Some parts manually.
I've added some TODO comments to the addresses, which I don't know how to fix.