search

waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
162 stars 41 forks source link

test: nwaku nodes started on The Waku Network requires a RPC endpoint #1914

Closed danisharora099 closed 2 months ago

danisharora099 commented 4 months ago

Problem

Within our tests suite, we have tests that also attempt connection with nodes started on cluster ID = 1 and after the v0.26.0 update, it expects a RPC endpoint passed along to fetch contract re data.

Proposed Solutions

rymnc commented 4 months ago

something that is tangentially related to this issue, please ensure that the rln_tree is persisted across runs so the nwaku nodes finish sync and startup quicker

danisharora099 commented 4 months ago

something that is tangentially related to this issue, please ensure that the rln_tree is persisted across runs so the nwaku nodes finish sync and startup quicker

Good point!

weboko commented 2 months ago

Moving to Priority as we need to address it sooner than later. For now tests are using different cluster IDs to avoid nwaku nodes from failing to run.

weboko commented 2 months ago

@fbarbu15 can you, please, give your input on this issue?

In particular, if we foresee many tests in future to use this?

fbarbu15 commented 2 months ago

On the interop testing side we use cluster id 1 only to test RLN. So the testing around this cluster is contained. Tests on this cluster id are also more complex and slower (node can take more than 1 minute to fully start) because of RLN so it's another reason to avoid it. So I think it will be the same case for js-waku tests

weboko commented 2 months ago

Summarizing - we foresee such tests in js-waku in future but not now. @adklempner merged the PR and the job is now skipped in CI.

Once it is needed I think QA team will re-enable this step and will update with needed changes.

Closing as complete.