search

waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
162 stars 41 forks source link

fix: check if process is defined before accessing it #1921

Closed vpavlin closed 4 months ago

vpavlin commented 4 months ago

Problem

When running the js-waku lab examples, accessing process directly breaks as the variable is undefined.

Solution

Check for process and process.env not being undefined

Notes

Contribution checklist:

github-actions[bot] commented 4 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 185.21 KB (0%) 3.8 s (0%) 21.4 s (+23.49% 🔺) 25.1 s
Waku Simple Light Node 185.41 KB (0%) 3.8 s (0%) 14.5 s (-33.5% 🔽) 18.2 s
ECIES encryption 22.88 KB (0%) 458 ms (0%) 3 s (-56.61% 🔽) 3.4 s
Symmetric encryption 22.42 KB (0%) 449 ms (0%) 4.2 s (-4.96% 🔽) 4.6 s
DNS discovery 73.67 KB (0%) 1.5 s (0%) 13.5 s (+8.01% 🔺) 15 s
Peer Exchange discovery 75.25 KB (0%) 1.6 s (0%) 12.9 s (+2.96% 🔺) 14.4 s
Local Peer Cache Discovery 68.99 KB (0%) 1.4 s (0%) 10.2 s (-22.37% 🔽) 11.6 s
Privacy preserving protocols 39.97 KB (0%) 800 ms (0%) 6.6 s (-14.99% 🔽) 7.4 s
Waku Filter 20.13 KB (0%) 403 ms (0%) 5.1 s (+1.7% 🔺) 5.6 s
Waku LightPush 115.5 KB (0%) 2.4 s (0%) 14.8 s (+84.84% 🔺) 17.1 s
History retrieval protocols 19.32 KB (0%) 387 ms (0%) 2.7 s (-32.35% 🔽) 3.1 s
Deterministic Message Hashing 4.96 KB (0%) 100 ms (0%) 502 ms (-29.48% 🔽) 601 ms