fix!: changing exports name from snake casing to camel case

waku-org / js-waku

JavaScript implementation of Waku v2

https://js.waku.org

Apache License 2.0

167 stars 42 forks source link

fix!: changing exports name from snake casing to camel case #1934

Closed varunsh20 closed 4 months ago

varunsh20 commented 6 months ago

Problem

Some exports are using snake casing within the codebase.

Solution

Have changed the exports name in core and proto packages to camel case.

Notes

Resolves #1933
Related to https://github.com/waku-org/js-waku/issues/1933

varunsh20 commented 6 months ago

@danisharora099 changes done. Correct me if I am wrong but I think some exports like waku_filter, waku_store and few others are not used currently. Rest I have changed.

danisharora099 commented 6 months ago

@danisharora099 changes done. Correct me if I am wrong but I think some exports like waku_filter, waku_store and few others are not used currently. Rest I have changed.

@varunsh20 Yes. Would suggest at fixing the CI runs which would implicitly take care a lot of smaller things. Will come back for a final review then

danisharora099 commented 5 months ago

Hi @varunsh20 are you still interested in this PR? If not, we can close it.