search

waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
162 stars 41 forks source link

fix: make rollup replace env var #1951

Closed weboko closed 3 months ago

weboko commented 3 months ago

Problem

process is not defined in rollup artifacts

Solution

adjust build system

github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 180.85 KB (0%) 3.7 s (0%) 716 ms (-21.76% 🔽) 4.4 s
Waku Simple Light Node 180.73 KB (0%) 3.7 s (0%) 725 ms (-38.07% 🔽) 4.4 s
ECIES encryption 23.11 KB (0%) 463 ms (0%) 195 ms (-33.97% 🔽) 658 ms
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 365 ms (+82.57% 🔺) 817 ms
DNS discovery 72.4 KB (0%) 1.5 s (0%) 477 ms (-5.37% 🔽) 2 s
Peer Exchange discovery 73.97 KB (0%) 1.5 s (0%) 569 ms (+7.98% 🔺) 2.1 s
Local Peer Cache Discovery 67.71 KB (0%) 1.4 s (0%) 480 ms (-13.31% 🔽) 1.9 s
Privacy preserving protocols 38.75 KB (0%) 775 ms (0%) 402 ms (-6.93% 🔽) 1.2 s
Waku Filter 20.17 KB (0%) 404 ms (0%) 116 ms (-62.04% 🔽) 519 ms
Waku LightPush 110.12 KB (0%) 2.3 s (0%) 822 ms (+8.16% 🔺) 3.1 s
History retrieval protocols 110.62 KB (0%) 2.3 s (0%) 648 ms (+8.65% 🔺) 2.9 s
Deterministic Message Hashing 4.83 KB (0%) 97 ms (0%) 10 ms (-17.86% 🔽) 106 ms
danisharora099 commented 3 months ago

Can you elaborate on this change with more details? Why is it undefined in the build artifiacts?

weboko commented 3 months ago

While validating RC I found out that we actually didn't quite fix the problem for rollup bundle but only for webpack. This PR attempts to replace any occurrence of process.env.NODE_ENV to production. This way there is no problems like the following one

image