search

waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
167 stars 42 forks source link

fix: Added missing values for HistoryError to be sync with nwaku #1952

Closed NagyZoltanPeter closed 5 months ago

NagyZoltanPeter commented 6 months ago

Problem

Find test failure in nwaku ci:

2024-04-09T09:49:52.0513572Z   8) Waku Store, general
2024-04-09T09:49:52.0513871Z        Query generator for 2000 messages:
2024-04-09T09:49:52.0514217Z      Error: Invalid enum value
2024-04-09T09:49:52.0514929Z       at findValue (file:///home/runner/work/nwaku/nwaku/node_modules/protons-runtime/src/codecs/enum.ts:9:13)
2024-04-09T09:49:52.0516150Z       at Object.enumDecode [as decode] (file:///home/runner/work/nwaku/nwaku/node_modules/protons-runtime/src/codecs/enum.ts:24:12)
2024-04-09T09:49:52.0517376Z       at Object.decode (file:///home/runner/work/nwaku/nwaku/packages/proto/src/generated/store.ts:451:64)
2024-04-09T09:49:52.0519087Z       at Object.decode (file:///home/runner/work/nwaku/nwaku/packages/proto/src/generated/store.ts:533:54)
2024-04-09T09:49:52.0521545Z       at decodeMessage (file:///home/runner/work/nwaku/nwaku/node_modules/protons-runtime/src/decode.ts:8:16)
2024-04-09T09:49:52.0522987Z       at Object.HistoryRpc.decode (file:///home/runner/work/nwaku/nwaku/packages/proto/src/generated/store.ts:557:12)
2024-04-09T09:49:52.0524260Z       at HistoryRpc.decode (file:///home/runner/work/nwaku/nwaku/packages/core/src/lib/store/history_rpc.ts:73:34)
2024-04-09T09:49:52.0525300Z       at StoreCore.queryPerPage (file:///home/runner/work/nwaku/nwaku/packages/core/src/lib/store/index.ts:110:37)
2024-04-09T09:49:52.0526135Z       at processTicksAndRejections (node:internal/process/task_queues:95:5)
2024-04-09T09:49:52.0526996Z       at async StoreSDK.queryGenerator (file:///home/runner/work/nwaku/nwaku/packages/sdk/src/protocols/store.ts:83:22)
2024-04-09T09:49:52.0527571Z

Found missing enum values from HistoryError in protobuf definition. Please help me elaborate this PR for me ;-)

github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 180.93 KB (+0.05% 🔺) 3.7 s (+0.05% 🔺) 1.7 s (-10.76% 🔽) 5.3 s
Waku Simple Light Node 180.85 KB (+0.07% 🔺) 3.7 s (+0.07% 🔺) 1.4 s (-11.9% 🔽) 5 s
ECIES encryption 23.12 KB (+0.06% 🔺) 463 ms (+0.06% 🔺) 507 ms (+27.26% 🔺) 970 ms
Symmetric encryption 22.57 KB (-0.07% 🔽) 452 ms (-0.07% 🔽) 612 ms (+33.04% 🔺) 1.1 s
DNS discovery 72.44 KB (+0.06% 🔺) 1.5 s (+0.06% 🔺) 731 ms (+14.97% 🔺) 2.2 s
Peer Exchange discovery 73.96 KB (-0.01% 🔽) 1.5 s (-0.01% 🔽) 1.2 s (+77.46% 🔺) 2.7 s
Local Peer Cache Discovery 67.71 KB (-0.01% 🔽) 1.4 s (-0.01% 🔽) 813 ms (-6.68% 🔽) 2.2 s
Privacy preserving protocols 38.78 KB (+0.07% 🔺) 776 ms (+0.07% 🔺) 610 ms (-21.81% 🔽) 1.4 s
Waku Filter 20.22 KB (+0.27% 🔺) 405 ms (+0.27% 🔺) 258 ms (-46.31% 🔽) 663 ms
Waku LightPush 110.13 KB (+0.01% 🔺) 2.3 s (+0.01% 🔺) 1.4 s (+30.51% 🔺) 3.6 s
History retrieval protocols 110.74 KB (+0.11% 🔺) 2.3 s (+0.11% 🔺) 997 ms (-52.61% 🔽) 3.3 s
Deterministic Message Hashing 4.83 KB (0%) 97 ms (0%) 33 ms (-28.62% 🔽) 130 ms
NagyZoltanPeter commented 5 months ago

@weboko: Can you help me? Is it "normal" that some of the CI checks fails? I see some peer discovery errors. This change is needed for my PR on nwaku as some interface has changed on protocol level.

adklempner commented 5 months ago

@weboko: Can you help me? Is it "normal" that some of the CI checks fails? I see some peer discovery errors. This change is needed for my PR on nwaku as some interface has changed on protocol level.

as long as all the required CI checks pass then it's considered good