search

waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
162 stars 41 forks source link

feat: lift contentTopics and make shardInfo mandatory for createLight… #1959

Closed weboko closed 2 months ago

weboko commented 2 months ago

Problem

End consumers might not want to understand the concept of sharding and wouldn't want to read the types.

Solution

Lift contentTopics option so that consumers just care about supplying a bunch of strings.

Notes

Additionally resolved https://github.com/waku-org/js-waku/issues/1980

github-actions[bot] commented 2 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 181.17 KB (+0.05% 🔺) 3.7 s (+0.05% 🔺) 23.5 s (+10.44% 🔺) 27.1 s
Waku Simple Light Node 181.16 KB (+0.02% 🔺) 3.7 s (+0.02% 🔺) 21.5 s (+21.4% 🔺) 25.1 s
ECIES encryption 23.08 KB (0%) 462 ms (0%) 2.9 s (-32.11% 🔽) 3.3 s
Symmetric encryption 22.55 KB (0%) 452 ms (0%) 3.6 s (-39.94% 🔽) 4 s
DNS discovery 72.42 KB (0%) 1.5 s (0%) 11.7 s (+50% 🔺) 13.2 s
Peer Exchange discovery 74.1 KB (0%) 1.5 s (0%) 15.7 s (+47.46% 🔺) 17.2 s
Local Peer Cache Discovery 67.64 KB (0%) 1.4 s (0%) 14.1 s (+17.21% 🔺) 15.5 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 6.5 s (-25.48% 🔽) 7.3 s
Waku Filter 111.58 KB (-0.17% 🔽) 2.3 s (-0.17% 🔽) 17.9 s (+11.11% 🔺) 20.1 s
Waku LightPush 110.15 KB (+0.05% 🔺) 2.3 s (+0.05% 🔺) 21.7 s (+117.7% 🔺) 23.9 s
History retrieval protocols 110.74 KB (+0.02% 🔺) 2.3 s (+0.02% 🔺) 15.9 s (+15.65% 🔺) 18.1 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 978 ms (-27.93% 🔽) 1.2 s