Closed danisharora099 closed 2 months ago
Reference to https://github.com/waku-org/js-waku/issues/1953, we see local storage related functionality breaking on node environments because localStorage is undefined.
localStorage
While js-waku is targeted for browser environments, we need to offer flexibility in terms of its usage in node environment without things breaking.
Allow dynamic imports to polyfill localStorage in node environments.
Contribution checklist:
!
closing this PR in favor of deprioritising nodejs
Problem
Reference to https://github.com/waku-org/js-waku/issues/1953, we see local storage related functionality breaking on node environments because
localStorage
is undefined.While js-waku is targeted for browser environments, we need to offer flexibility in terms of its usage in node environment without things breaking.
Solution
Allow dynamic imports to polyfill
localStorage
in node environments.Notes
Contribution checklist:
!
in title if breaks public API;