github-actions[bot]
commented
2 months ago size-limit report 📦
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| Waku node | 181.24 KB (+0.02% 🔺) | 3.7 s (+0.02% 🔺) | 13.7 s (+10.02% 🔺) | 17.3 s |
| Waku Simple Light Node | 181.32 KB (+0.06% 🔺) | 3.7 s (+0.06% 🔺) | 10.9 s (-52.21% 🔽) | 14.5 s |
| ECIES encryption | 23.12 KB (+0.19% 🔺) | 463 ms (+0.19% 🔺) | 4.5 s (-9.39% 🔽) | 4.9 s |
| Symmetric encryption | 22.53 KB (-0.1% 🔽) | 451 ms (-0.1% 🔽) | 4 s (-6.95% 🔽) | 4.4 s |
| DNS discovery | 72.5 KB (+0.11% 🔺) | 1.5 s (+0.11% 🔺) | 7.4 s (-51.72% 🔽) | 8.9 s |
| Peer Exchange discovery | 74.09 KB (-0.02% 🔽) | 1.5 s (-0.02% 🔽) | 9.2 s (-3.59% 🔽) | 10.7 s |
| Local Peer Cache Discovery | 67.63 KB (-0.03% 🔽) | 1.4 s (-0.03% 🔽) | 9.1 s (-39.91% 🔽) | 10.5 s |
| Privacy preserving protocols | 38.88 KB (+0.04% 🔺) | 778 ms (+0.04% 🔺) | 8.3 s (-14.03% 🔽) | 9.1 s |
| Waku Filter | 111.72 KB (-0.07% 🔽) | 2.3 s (-0.07% 🔽) | 22.5 s (+72.79% 🔺) | 24.8 s |
| Waku LightPush | 110.26 KB (+0.1% 🔺) | 2.3 s (+0.1% 🔺) | 16.7 s (+6.03% 🔺) | 18.9 s |
| History retrieval protocols | 110.76 KB (+0.02% 🔺) | 2.3 s (+0.02% 🔺) | 22.3 s (+143.7% 🔺) | 24.5 s |
| Deterministic Message Hashing | 7.24 KB (-0.15% 🔽) | 145 ms (-0.15% 🔽) | 2.3 s (+129.65% 🔺) | 2.4 s |
Problem
The Filter implementation currently
throwsErrorto handle non-success scenarios. This needs a change to using error codes instead: #1694Solution
Move all
throws to returning error codesNotes