fix(tests): remove delays between dials

waku-org / js-waku

JavaScript implementation of Waku v2

https://js.waku.org

Apache License 2.0

167 stars 42 forks source link

fix(tests): remove delays between dials #1977

Open danisharora099 opened 5 months ago

danisharora099 commented 5 months ago

This is a bug report

Problem

nwaku<>js-waku interop saw flakiness when we dial two nwaku nodes, from js-waku, one after the other -- the connections seems to be dropping.

adding a small delay of 500ms between the two dials seems to have fixed it -- https://github.com/waku-org/js-waku/pull/1973/files

Proposed Solutions

Investigate why the delays needed to be add
Remove the delays

weboko commented 5 months ago

Maybe @fbarbu15 has any input or ideas on it.

fbarbu15 commented 4 months ago

Unfortunately no, I don't have any real clue what caused this flaky tests. Maybe a race condition? gabrielmer discovered this issue/fix, maybe he knows more