search

waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
162 stars 41 forks source link

chore: fail when both pubsubTopics and shardInfo are specified #1980

Closed vpavlin closed 2 months ago

vpavlin commented 2 months ago
This is a **change request** ## Problem When setting up light node, users can specify both `pubsubTopics` and `shardInfo` which seems to result in unwanted behaviour ## Proposed Solutions Error out when both `pubsubTopics` and `shardInfo` are specified and suggest only one is provided ## Notes
weboko commented 2 months ago

Addressing it here - ensureShardingConfigured

weboko commented 2 months ago

I jumped into conclusion that there is actually a problem - but after checking in one of my local examples or testing pipeline we have currently https://github.com/waku-org/js-waku/pull/1992 - there seems to be no error.

Of course I agree this shouldn't happen - and some warning should be printed.

@vpavlin please, share details what actually fails?