waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
167 stars 42 forks source link

fix: add shard arg to nwaku in peer management tests #2005

Closed adklempner closed 4 months ago

adklempner commented 4 months ago

Problem

Tests for checking that connection manager dials the correct peers based on sharding params were failing against nwaku

Solution

1. Add `NODE_ENV=test` to env vars when running tests 2. Add `shard` argument when starting nwaku 3. Use correct `shard` arguments when running tests in `peer_management.spec.ts` ## Notes

Contribution checklist:

github-actions[bot] commented 4 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 181.21 KB (0%) 3.7 s (0%) 17.8 s (-13.26% 🔽) 21.5 s
Waku Simple Light Node 181.21 KB (0%) 3.7 s (0%) 20 s (-7.95% 🔽) 23.6 s
ECIES encryption 23.08 KB (0%) 462 ms (0%) 4.9 s (+23.67% 🔺) 5.3 s
Symmetric encryption 22.55 KB (0%) 452 ms (0%) 6.1 s (-25.02% 🔽) 6.5 s
DNS discovery 72.42 KB (0%) 1.5 s (0%) 13.1 s (+18.54% 🔺) 14.5 s
Peer Exchange discovery 74.1 KB (0%) 1.5 s (0%) 10 s (-41.08% 🔽) 11.5 s
Local Peer Cache Discovery 67.64 KB (0%) 1.4 s (0%) 15 s (+9.18% 🔺) 16.4 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 5 s (-48.04% 🔽) 5.8 s
Waku Filter 111.79 KB (0%) 2.3 s (0%) 13.5 s (-23.7% 🔽) 15.7 s
Waku LightPush 110.15 KB (0%) 2.3 s (0%) 14.5 s (-7.94% 🔽) 16.7 s
History retrieval protocols 110.74 KB (0%) 2.3 s (0%) 15.3 s (-9.94% 🔽) 17.5 s
Deterministic Message Hashing 7.25 KB (0%) 145 ms (0%) 2.1 s (+153.45% 🔺) 2.2 s