waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
162 stars 41 forks source link

chore(store): align protocol implementation to use `BaseProtocolSDK` #2019

Closed danisharora099 closed 4 weeks ago

danisharora099 commented 1 month ago

Problem

The store protocol currently only uses one peer to make a query - https://github.com/waku-org/js-waku/issues/1685

Solution

Notes

Contribution checklist:

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 181.37 KB (-0.01% 🔽) 3.7 s (-0.01% 🔽) 4.8 s (-33.14% 🔽) 8.4 s
Waku Simple Light Node 181.67 KB (+0.08% 🔺) 3.7 s (+0.08% 🔺) 4.1 s (-22.72% 🔽) 7.7 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 1.5 s (+121.32% 🔺) 2 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 1.8 s (+38.21% 🔺) 2.3 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 2.8 s (-18.47% 🔽) 4.3 s
Peer Exchange discovery 74.15 KB (0%) 1.5 s (0%) 3.9 s (-2.79% 🔽) 5.4 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 3.2 s (+10.28% 🔺) 4.5 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 2.7 s (+88.91% 🔺) 3.5 s
Waku Filter 111.98 KB (-0.04% 🔽) 2.3 s (-0.04% 🔽) 4.6 s (+25.3% 🔺) 6.8 s
Waku LightPush 110.39 KB (0%) 2.3 s (0%) 4.5 s (+23.89% 🔺) 6.7 s
History retrieval protocols 111.23 KB (+0.29% 🔺) 2.3 s (+0.29% 🔺) 2.3 s (-45.87% 🔽) 4.5 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 572 ms (-7.23% 🔽) 718 ms
danisharora099 commented 4 weeks ago

As concluded in https://github.com/waku-org/js-waku/issues/1685#issuecomment-2149388106, this is now being deprioritsed. Closing PR.