Open vpavlin opened 1 month ago
WDYT @weboko ?
@vpavlin, what is the case for users to specify both shardInfo
and pubsubTopics
?
No idea:) I think the case is specifying contentTopic
and pubsubTopic
- maybe even unintentionally without fully understanding what they are doing?
Consider this with assumption js-waku works with TWN:
contentTopic
and lean on TWNpubsubTopic
assuming that is all I needThe actual case is this change https://github.com/waku-org/js-waku/commit/5b03709dfe683b1cb001fe67c5bd013e664b4d89 broke things that previously worked - i.e. contentTopic and pubsubTopic specified at once.
Regardless of what the use case for having both shardInfo
and pubsubTopic
js-waku should let users know they should not specify both - i.e. report the error - as I suggested in the description.
I think this is something that is not clear and we need more feedback on it. Overall I think node should be run either in TWN or on custom network, not both.
For action point for this task I think we should refine createNode
options as they are confusing.
My approach would be to:
pusbTopic
or shardInfo
;Slightly intervened with https://github.com/waku-org/js-waku/issues/2034