waku-org / js-waku

JavaScript implementation of Waku v2
https://js.waku.org
Apache License 2.0
162 stars 41 forks source link

chore: merge `ProtocolUseOptions` and `ProtocolCreateOptions` #2048

Open danisharora099 opened 1 week ago

danisharora099 commented 1 week ago

This is a change request

Problem

Based on the introduction of ProtocolUseOptions in https://github.com/waku-org/js-waku/pull/2047, there is some merit in keeping one type with ProtocolCreateOptions.

They have keys which might have better correlation with keys from the other type.

Proposed Solutions

Either form a clear distinction, or merge, the type ProtocolUseOptions with ProtocolCreateOptions