Open danisharora099 opened 1 month ago
Another point to address https://github.com/waku-org/js-waku/pull/2085#discussion_r1691754059:
createLightNode
/createRelayNode
directly and instead create createTestLightNode
/createTestRelayNode
util that will be configured for DefaultTestShardInfo
and other test defaults;runNode
/runStoreNode
/runNodeBuilder
/runNodes
utils in favor of one and do not pass any shardInfo
as it defaults to DefaultTestShardInfo
;PubsubTopics
/ShardInfo
etc and use only DefaultTestShardInfo
/DefaultTestPubsubTopic
;
This is a change request
Problem
We have different utils being setup for different tests, specifically protocols. This, in places, is starting to get redundant and would be good to keep
/tests/
folder strictlyspec
files while all utils can live in/src/
instead (along with other utils)Proposed Solutions
Abstract away different utils like https://github.com/waku-org/js-waku/blob/master/packages/tests/tests/filter/utils.ts and https://github.com/waku-org/js-waku/blob/04bd518210a709b3b01ada5be947e653912201ba/packages/tests/tests/store/utils.ts#L103 into root level utils (in
/src
perhaps)Notes