waku-org / lab.waku.org

🔬 JS Waku little laboratory
https://lab.waku.org
Apache License 2.0
0 stars 1 forks source link

bug: fix flush-notes #78

Open weboko opened 3 months ago

weboko commented 3 months ago

Problem

Currently flush-notes is not working due to problem with NextJS paths.

image

Solution

Update deploy step so that it copies out directory of flush-notes with _next, currently it doesn't in https://github.com/waku-org/lab.waku.org/blob/fcbf3539e0f41208b1ee9ebe5bcc70f3a2d12493/ci/Jenkinsfile#L86 image

Then we should fix paths in the output so that it loads js files and others from subfolder in lab.waku.org/flush-notes/_next. I couldn't find a way to do this through next.config.js so we should use following: https://github.com/vercel/next.js/discussions/45422#discussioncomment-7593569

image

Notes

weboko commented 2 months ago