search

waku-org / nwaku-compose

Deployment docker-compose files to deploy an nwaku node
13 stars 22 forks source link

feat: add support for cors and integrate waku-frontend #30

Closed weboko closed 1 month ago

weboko commented 11 months ago

@gabrielmer do we need to use custom nwaku image or latest to have the fix for cors?

gabrielmer commented 10 months ago

@gabrielmer do we need to use custom nwaku image or latest to have the fix for cors?

To have the fix for CORS we currently need the custom image wakuorg/nwaku:debug-cors-wa until fixes get merged to both nim-presto and nwaku.

If necessary I can create an image with a more meaningful/appropriate name

weboko commented 10 months ago

This PR should be ready now.

alrevuelta commented 10 months ago

LGTM until we get the CORS fix into master. @alrevuelta what do you think?

I would prefer to wait until we have the cors issue fixed in a release, unless this blocks something else.

weboko commented 10 months ago

I would prefer to wait until we have the cors issue fixed in a release, unless this blocks something else.

Fine by me, just to clarify - Chat is not working without it

Ivansete-status commented 2 months ago

Morning @weboko ! I think this can be closed now given that we currently supporting the frontend

Ivansete-status commented 1 month ago

@weboko confirmed that we can close that one. Thanks for it :raised_hands: !