waku-org / nwaku-compose

Deployment docker-compose files to deploy an nwaku node
13 stars 22 forks source link

fix: removed mkdir keystore before rln registration run #45

Closed NagyZoltanPeter closed 8 months ago

NagyZoltanPeter commented 8 months ago

It was found on sandbox machine that creating the keystore dir ahead of docker run can cause permission issue writing in it. Docker run will create the missing directory by its own when mounting it.

I made several tries. On sandbox machine it is only working when no keystore directory exists before docker run of wakunode. On my local machine it works both ways.

Ivansete-status commented 8 months ago

That's amazing! Thanks so much!

@Ivansete-status maybe this was the cause of all the permission issues we saw?

This issue has helped discover the possible reason for the one you mentioned, Gabriel (https://github.com/waku-org/nwaku-compose/issues/32.)

We are waiting for @NagyZoltanPeter to be added to the adm group in the sandbox machine, and, if after that he can register properly even having the mkdir -p keystore command, that would mean that we are closer to understand the problem of "Cannot open file for writing".

NagyZoltanPeter commented 8 months ago

That's amazing! Thanks so much! @Ivansete-status maybe this was the cause of all the permission issues we saw?

This issue has helped discover the possible reason for the one you mentioned, Gabriel (#32.)

We are waiting for @NagyZoltanPeter to be added to the adm group in the sandbox machine, and, if after that he can register properly even having the mkdir -p keystore command, that would mean that we are closer to understand the problem of "Cannot open file for writing".

Actually I did try it before issued this PR. Even with adm group involvement it just runs the same for me. Meaning creating directory from the script (with user creds) before docker run ends in write permission error. Deleting the directory first and let docker create the keystore dir runs OK. As having this case common in local machine and in sandbox better remove that mkdir.