search

waku-org / nwaku-compose

Deployment docker-compose files to deploy an nwaku node
13 stars 22 forks source link

Use a generic image instead of hard-coded version #57

Closed Ivansete-status closed 5 months ago

Ivansete-status commented 8 months ago

We should use a "nwaku-compose-latest" image tag to upgrade it on each release and not update the docker-compose.yml each time.

The question was raised by @jakubgs . Feel free to add any comment I may miss.

jakubgs commented 8 months ago

I don't believe I ever said that. I think an explicit version make sense, it should just be overwriteable.

jakubgs commented 5 months ago

Having a moving target is bad. I would be against this. You should use known working versions than try to use moving target that will work or not work depending on when you use the compose.

alrevuelta commented 5 months ago

Agree. A "nwaku-compose-latest" is not deterministic. Lets use a hardcoded one but with the possibility of overriding it like we already have using NWAKU_IMAGE.