search

waku-org / nwaku

Waku node and protocol.
Other
201 stars 53 forks source link

feat: move protocol wire format codecs to nim-protobuf-serialization #1361

Open LNSD opened 1 year ago

LNSD commented 1 year ago

Background

TBD

Details

TBD

Acceptance criteria

TBD

arnetheduck commented 1 year ago

keep in mind that there's a major rewrite due here: https://github.com/status-im/nim-protobuf-serialization/pull/36 - it needs more unit tests above all, in case you want to help push it along ;)

LNSD commented 1 year ago

keep in mind that there's a major rewrite due here: status-im/nim-protobuf-serialization#36 - it needs more unit tests above all, in case you want to help push it along ;)

I added this as a placeholder. Currently, I am concerned about how we manage protobufs in nwaku and the type mapping. I was thinking of putting some effort into improving it, but it may be worth pushing a joint initiative instead of having multiple implementations. Thanks for the heads up