waku-org / nwaku

Waku node and protocol.
Other
202 stars 53 forks source link

feat(rln-relay): v0.14.0 Release #1376

Closed rymnc closed 1 year ago

rymnc commented 1 year ago
### Problem This is to keep track of the rln-relay features to be ready for integration in the next nwaku release 0.14.0. - [x] https://github.com/status-im/nwaku/issues/1270 - [x] https://github.com/waku-org/nwaku/pull/1445 - Tracking Lightpush with rln-relay here: https://github.com/waku-org/nwaku/issues/1226 - [x] General maintenance (@rymnc) - [x] https://github.com/status-im/nwaku/issues/1358 - [x] https://github.com/waku-org/nwaku/pull/1457 - [x] Static rln lib compilation (@s1fr0 and @LNSD) - https://github.com/status-im/nwaku/issues/1380 - [x] CI feature flagged jobs/checks (@rymnc) - [x] #1410 - [x] RLN [Barrel imports](https://basarat.gitbook.io/typescript/main-1/barrel) (@rymnc) - [x] #1386 - [x] Add support to Semaphore credentials generation: - https://github.com/waku-org/nwaku/issues/1450 - https://github.com/waku-org/nwaku/pull/1459 There are a couple of other low-hanging fruits which we can attempt in case the above list is completed earlier than the deadline. ## Acceptance criteria Getting the listed features ready and tested by the indicated deadline below. Making sure there is no regression regarding the added features on the waku v2 fleets. ## Deadline January 9, 2023 (one week prior to the next release date) cc: @jm-clius @oskarth
staheri14 commented 1 year ago

Following our call today with @LNSD and @s1fr0 (and another call with @rymnc), below are a non-exhaustive set of refactoring tasks to be tackled (from https://notes.status.im/oozxlJl4QSiEhADbzTEXxA?view):

Tasks that can be attacked independently The tasks of this section have no specific dependency on other refactoring tasks, so they can be done in parallel or in any desired order.

Tasks with dependency The tasks listed here should be tackled in the same order they appear below. This is to minimize the code conflicts and have a speedy development and PR review process.

As discussed in the call, please tackle each one in a single PR and keep PRs self-contained.

Any comments?

LNSD commented 1 year ago

Any comments?

One little comment 😁

As we discussed, the listed tasks correspond to the first part of the refactoring effort; it is very likely that as these tasks progress and the code changes are reviewed, we will better understand the remaining work, and we'll be in the position to plan and prioritize the second part.

P.S. Thanks for listening to me. We are on the good path and moving forward πŸ‘πŸΌπŸ˜

staheri14 commented 1 year ago

it is very likely that as these tasks progress and the code changes are reviewed,

Correct! it is just the first cut, the list may evolve as we progress. cc: @rymnc @s1fr0

staheri14 commented 1 year ago

I see there are some updates on the issue description e.g., the deadline. It would be great if after each update we add a comment to this issue and announce it so that the integrated changes get attention.

LNSD commented 1 year ago

Adding the following task/PR to the list:

rymnc commented 1 year ago

@s1fr0 and I have discussed that we are moving the following sections to the next release -

LNSD commented 1 year ago

@s1fr0 and I have discussed that we are moving the following sections to the next release -

  • wallet integration into rln-relay
  • robustness of rln-relay
  • redeploy rln-contract The v0.15.0 issue will include them

Please, update this issue description accordingly.

We can also file a v0.15.0 issue containing those items (up to you).

rymnc commented 1 year ago

Updated the issue description. I'll create the v0.15.0 issue soon :)

rymnc commented 1 year ago

Created the v0.15.0 issue - https://github.com/waku-org/nwaku/issues/1486

jm-clius commented 1 year ago

@rymnc anything to do here before we close the issue?

rymnc commented 1 year ago

If it looks okay to @s1fr0, we can close it!

s1fr0 commented 1 year ago

Thanks @rymnc ! Updated description with some missing elements. Ok for me, I'll close the issue!