Closed rymnc closed 1 year ago
Following our call today with @LNSD and @s1fr0 (and another call with @rymnc), below are a non-exhaustive set of refactoring tasks to be tackled (from https://notes.status.im/oozxlJl4QSiEhADbzTEXxA?view):
Tasks that can be attacked independently The tasks of this section have no specific dependency on other refactoring tasks, so they can be done in parallel or in any desired order.
Tasks with dependency The tasks listed here should be tackled in the same order they appear below. This is to minimize the code conflicts and have a speedy development and PR review process.
As discussed in the call, please tackle each one in a single PR and keep PRs self-contained.
Any comments?
Any comments?
One little comment π
As we discussed, the listed tasks correspond to the first part of the refactoring effort; it is very likely that as these tasks progress and the code changes are reviewed, we will better understand the remaining work, and we'll be in the position to plan and prioritize the second part.
P.S. Thanks for listening to me. We are on the good path and moving forward ππΌπ
it is very likely that as these tasks progress and the code changes are reviewed,
Correct! it is just the first cut, the list may evolve as we progress. cc: @rymnc @s1fr0
I see there are some updates on the issue description e.g., the deadline. It would be great if after each update we add a comment to this issue and announce it so that the integrated changes get attention.
Adding the following task/PR to the list:
@s1fr0 and I have discussed that we are moving the following sections to the next release -
@s1fr0 and I have discussed that we are moving the following sections to the next release -
- wallet integration into rln-relay
- robustness of rln-relay
- redeploy rln-contract The v0.15.0 issue will include them
Please, update this issue description accordingly.
We can also file a v0.15.0 issue containing those items (up to you).
Updated the issue description. I'll create the v0.15.0 issue soon :)
Created the v0.15.0 issue - https://github.com/waku-org/nwaku/issues/1486
@rymnc anything to do here before we close the issue?
If it looks okay to @s1fr0, we can close it!
Thanks @rymnc ! Updated description with some missing elements. Ok for me, I'll close the issue!