waku-org / nwaku

Waku node and protocol.
Other
199 stars 51 forks source link

chore(rln-relay): integrate waku-org/waku-rln-contract #1871

Open rymnc opened 1 year ago

rymnc commented 1 year ago

Background

Since waku will run their own version of the rln contract for the first waku public network, to make integration easier, we need to ensure that the tests use the appropriate contract bytecode.

Details

Use https://waku-org/waku-rln-contract as a submodule, and fetch the bytecode from the deployed contracts for unit tests

Acceptance criteria

A list of tasks that need to be done for the issue to be considered resolved.

rymnc commented 1 year ago

cc: @jm-clius for a thumbs up before I start working on this! :)

vpavlin commented 1 year ago

Is the node operator expected to specify a chainId (to find the right contract address from allDeployments.json?

When you say fetched, do you mean from the submodule or from the blockchain node?

rymnc commented 1 year ago
  1. we'll have a sensible default set up, but yes, we'll have to ask them to pass in a chain name where we have mappings to the appropriate chain id

  2. fetched from the submodule :)

jm-clius commented 1 year ago

Sounds reasonable to me. 👍