Open rymnc opened 1 year ago
cc: @jm-clius for a thumbs up before I start working on this! :)
Is the node operator expected to specify a chainId (to find the right contract address from allDeployments.json
?
When you say fetched, do you mean from the submodule or from the blockchain node?
we'll have a sensible default set up, but yes, we'll have to ask them to pass in a chain name where we have mappings to the appropriate chain id
fetched from the submodule :)
Sounds reasonable to me. 👍
Background
Since waku will run their own version of the rln contract for the first waku public network, to make integration easier, we need to ensure that the tests use the appropriate contract bytecode.
Details
Use https://waku-org/waku-rln-contract as a submodule, and fetch the bytecode from the deployed contracts for unit tests
Acceptance criteria
A list of tasks that need to be done for the issue to be considered resolved.
allDeployments.json
file, making the--rln-relay-eth-contract-address
optional