waku-org / nwaku

Waku node and protocol.
Other
199 stars 51 forks source link

feat: Enforce service specific rate limits #2032

Open Ivansete-status opened 11 months ago

Ivansete-status commented 11 months ago

Problem

We are aiming to enforce DoS protection per libp2p services.

In this feature, we consider the limitation applied to the non-Relay protocols (lightpush, peer exchange, store, rendezvous, filter.) because the Relay protocol will benefit from the RLN protection.

Suggested solution

  1. Apply different limits per service (lightpush, peer exchange, store, rendezvous, filter.)
  2. Apply one single limit to be followed by all the libp2p protocols

Additional context

The issue originated from this great proposal: https://github.com/waku-org/go-waku/issues/667

Acceptance criteria

Tasks

chair28980 commented 4 months ago

@NagyZoltanPeter @Ivansete-status does the completion of https://github.com/waku-org/nwaku/issues/1809 cover the acceptance criteria here? Safe to close this issue?

NagyZoltanPeter commented 4 months ago

@NagyZoltanPeter @Ivansete-status does the completion of #1809 cover the acceptance criteria here? Safe to close this issue?

@chair28980 @Ivansete-status : I would not close this one yet. I'm about to finish phase2 of this. Last week I redesinged a bit the phase1 rate limit implementation in order to be more generic applicable to all non-relay protocols. Will be PR on THU this week. It will address Alvaro's concerns he made on the phase1 and will add bandwidth metrics also.