search

waku-org / nwaku

Waku node and protocol.
Other
183 stars 46 forks source link

refactor: addition of waku_api/rest/builder.nim and reduce app.nim #2623

Closed Ivansete-status closed 3 weeks ago

Ivansete-status commented 3 weeks ago

Description

Extract some REST logic from app.nim, aiming for simplify app.nim a little. I will submit a couple of similar PRs simplifying app.nim.

note: this has the same goal as https://github.com/waku-org/nwaku/pull/2610 but I decided to submit a different one just to keep the original one as a temporary reference. I will drop the initial PR once this gets merged

github-actions[bot] commented 3 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2623-rln-v2

Built from 14f1673c49c88dbc1cf09f448b82e0c63c8c31a6

github-actions[bot] commented 3 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2623-rln-v1

Built from 14f1673c49c88dbc1cf09f448b82e0c63c8c31a6

Ivansete-status commented 3 weeks ago

@NagyZoltanPeter - what do you mean in these questions?

But why to run an http service and open port while it is explicitly told on cli not to do so? I would not expose any port and consume resource in case it is not needed. WDYT?

NagyZoltanPeter commented 3 weeks ago

@NagyZoltanPeter - what do you mean in these questions?

But why to run an http service and open port while it is explicitly told on cli not to do so? I would not expose any port and consume resource in case it is not needed. WDYT?

@Ivansete-status We discussed in dm and you fixed. It was just about not to start restServer if configured --rest=false